[Bug]: Renaming github_repository doesn't taint full_name attribute #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenSpur
changed the title
|
Waiting on resolving these conflicts before merging! |
kfcampbell
approved these changes
Jun 27, 2023
doonga
referenced
this pull request
in doonga/greyrock-ops
Jun 29, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://github.com/integrations/terraform-provider-github)) | required_provider | minor | `5.28.1` -> `5.29.0` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.29.0`](https://github.com/integrations/terraform-provider-github/releases/tag/v5.29.0) [Compare Source](https://github.com/integrations/terraform-provider-github/compare/v5.28.1...v5.29.0) #### What's Changed - fix: support team slug in github_team_membership by [@​kristian-lesko](https://github.com/kristian-lesko) in [https://github.com/integrations/terraform-provider-github/pull/1751](https://github.com/integrations/terraform-provider-github/pull/1751) - Fixes accidental deletion of Repository resource from state by [@​t0yv0](https://github.com/t0yv0) in [https://github.com/integrations/terraform-provider-github/pull/1750](https://github.com/integrations/terraform-provider-github/pull/1750) - feat: Add GitHub Organization Custom Role Resource and Data Source by [@​cailen](https://github.com/cailen) in [https://github.com/integrations/terraform-provider-github/pull/1700](https://github.com/integrations/terraform-provider-github/pull/1700) - Fix typo in deployment branch policy import by [@​bpaquet](https://github.com/bpaquet) in [https://github.com/integrations/terraform-provider-github/pull/1758](https://github.com/integrations/terraform-provider-github/pull/1758) - Fix `resourceGithubDependabotOrganizationSecretCreateOrUpdate` by [@​frankywahl](https://github.com/frankywahl) in [https://github.com/integrations/terraform-provider-github/pull/1759](https://github.com/integrations/terraform-provider-github/pull/1759) - \[Bug]: Renaming github_repository doesn't taint full_name attribute by [@​KenSpur](https://github.com/KenSpur) in [https://github.com/integrations/terraform-provider-github/pull/1756](https://github.com/integrations/terraform-provider-github/pull/1756) - feat: Ability to Manage Codespaces Secrets by [@​KenSpur](https://github.com/KenSpur) in [https://github.com/integrations/terraform-provider-github/pull/1729](https://github.com/integrations/terraform-provider-github/pull/1729) #### New Contributors - [@​kristian-lesko](https://github.com/kristian-lesko) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1751](https://github.com/integrations/terraform-provider-github/pull/1751) - [@​t0yv0](https://github.com/t0yv0) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1750](https://github.com/integrations/terraform-provider-github/pull/1750) - [@​cailen](https://github.com/cailen) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1700](https://github.com/integrations/terraform-provider-github/pull/1700) - [@​frankywahl](https://github.com/frankywahl) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1759](https://github.com/integrations/terraform-provider-github/pull/1759) - [@​KenSpur](https://github.com/KenSpur) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1756](https://github.com/integrations/terraform-provider-github/pull/1756) **Full Changelog**: integrations/terraform-provider-github@v5.28.1...v5.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMCIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ntegrations#1756) * set full_name new computed on name change & add tests * Run go fmt ./... --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1305 #1755
Behavior
Before the change?
github_repository.namedid not setfull_namedirectly to (known after apply) so it required 2 applies to get the correct value out offull_namein dependent resources.After the change?
github_repository.namewill setfull_nameto new computed so that it is in a state of (known after apply), and doesnt need 2 applies to get the correct value in dependent resources.Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance